logging was broken if you didnt set a handler

This commit is contained in:
cloudwithax 2023-03-13 19:44:46 -04:00
parent 14ba273d35
commit 206adbd70b
3 changed files with 4 additions and 43 deletions

View File

@ -1,39 +0,0 @@
# This workflow will upload a Python Package using Twine when a release is created
# For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-python#publishing-to-package-registries
# This workflow uses actions that are not certified by GitHub.
# They are provided by a third-party and are governed by
# separate terms of service, privacy policy, and support
# documentation.
name: Upload Python Package
on:
release:
types: [published]
permissions:
contents: read
jobs:
deploy:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Set up Python
uses: actions/setup-python@v3
with:
python-version: '3.x'
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install build
- name: Build package
run: python -m build
- name: Publish package
uses: pypa/gh-action-pypi-publish@27b31702a0e7fc50959f5ad993c78deac1bdfc29
with:
user: __token__
password: ${{ secrets.PYPI_API_TOKEN }}

View File

@ -147,6 +147,7 @@ class Player(VoiceProtocol):
) -> None:
self.client: Client = client
self.channel: VoiceChannel = channel
self._guild = channel.guild
self._bot: Client = client
self._node: Node = node if node else NodePool.get_node()

View File

@ -112,7 +112,7 @@ class Node:
apple_music: bool = False,
fallback: bool = False,
log_level: LogLevel = LogLevel.INFO,
log_handler: Optional[logging.Handler] = MISSING,
log_handler: Optional[logging.Handler] = None,
):
self._bot: commands.Bot = bot
self._host: str = host
@ -221,10 +221,9 @@ class Node:
logger.setLevel(level)
handler = None
if self._log_handler is not None:
if self._log_handler:
handler = self._log_handler
elif self._log_handler is MISSING:
else:
handler = logging.StreamHandler()
dt_fmt = "%Y-%m-%d %H:%M:%S"
formatter = logging.Formatter(